Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ClientCollateral when validating deal proposal #408

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Sep 21, 2020

Problem

Previously, we weren't including the client collateral when considering storage deal proposals; it was assumed it was always 0.

Solution

Use ClientBalanceRequirement() when verifying client funds, which includes the client collateral.

Resolves filecoin-project/lotus/issues/3864

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward force-pushed the fix/validate-client-collateral-3864 branch from bcf46a9 to a647860 Compare September 23, 2020 16:38
@codecov-commenter
Copy link

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files          44       44           
  Lines        2714     2714           
=======================================
  Hits         1661     1661           
  Misses        889      889           
  Partials      164      164           
Impacted Files Coverage Δ
...oragemarket/impl/providerstates/provider_states.go 83.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99bb3c...a647860. Read the comment docs.

@hannahhoward hannahhoward merged commit b04a811 into master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markets should use ClientBalanceRequirement to check client has sufficient funds
3 participants